Problem/Motivation

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_authentication/src/AuthenticationServers.php                                                                                                          
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  38     Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_authentication/src/Form/LdapAuthenticationAdminForm.php                                                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  85     Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_authentication/tests/src/Unit/AuthenticationServersTest.php                                                                                           
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  45     Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_authentication/tests/src/Unit/ModuleTest.php                                                                                                          
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  80     Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_authorization/tests/src/Unit/LdapAuthorizationProviderTest.php                                                                                        
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  86     Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 


 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_query/src/Controller/QueryController.php                                                                                                              
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  77     Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_servers/src/LdapBridge.php                                                                                                                            
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  76     Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_servers/src/ServerListBuilder.php                                                                                                                                    
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  38     Direct injection of entity storage via $storage is not recommended. Inject Drupal\Core\Entity\EntityTypeManagerInterface and call getStorage() at the call-site instead.  
         🪪  drupal.entityStorageDirectInjection                                                                                                                                   
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                                
  40     Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.                 
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                                
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                                                                                                                                                         
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_servers/tests/modules/ldap_servers_dummy/src/FakeBridge.php                                                                                           
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  56     Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_servers/tests/src/Unit/Form/ServerTestFormTest.php                                                                                                    
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  121    Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_servers/tests/src/Unit/ServerListBuilderTest.php                                                                                                      
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  61     Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   ldap_user/src/Processor/GroupUserUpdateProcessor.php                                                                                                       
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------- 
  157    Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.  
         🪪  drupal.entityStoragePropertyAssignment                                                                                                                 
         💡  See https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal                                                                                 
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------

Debug Report

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ldap-3619807

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bluegeek9 created an issue. See original summary.

bluegeek9 opened merge request !125

  • bluegeek9 committed 20aa028a on 8.x-4.x 
    task: #3619807 Storing entity storage as a class property is not...
bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.