Problem/Motivation

Follow-up of #3608929: Adopt php-cs-fixer ruleset about adding php-cs-fixer to the pipeline

Issue fork ui_patterns-3619588

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

just_like_good_vibes created an issue. See original summary.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Related issues: +#3608929: Adopt php-cs-fixer ruleset

just_like_good_vibes opened merge request !552

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Active » Needs review
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: Unassigned » grimreaper
pdureau’s picture

pdureau commented
Status: Needs review » Reviewed & tested by the community

A little review to assist @grimreaper (which may be unavailable today).

I am OK with the changes:

  • on .php-cs-fixer.php because i have noticed the same incompatibilities with the phpunit and phpcs we are using
  • on .gitlab-ci.yml because it is adding the too to pipeline
  • on the codebase because it is simply the run of php-cs-fixer on the current state of the module
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » just_like_good_vibes

Approved, thanks a lot!

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.