Problem/Motivation

In #3614964: Remove install of Olivero from tests we committed a test that is not being run because the directory has a capital S in it. This was picked up on the 11.x pipeline for some reason and not the main branch.

Steps to reproduce

Try to run the test with phpunit.xml.dist's glob

Proposed resolution

Fix the directory name

Remaining tasks

N/A

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3619402

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !16869

acbramley’s picture

acbramley commented
Status: Active » Needs review
Related issues: +#3614964: Remove install of Olivero from tests
kieran.cott’s picture

kieran.cott
Location Manila 🇵🇭
commented

LGTM, only change here is renaming core/themes/olivero/tests/src/FunctionalJavaScript/AjaxTest.php to core/themes/olivero/tests/src/FunctionalJavascript/AjaxTest.php; exactly as the issue describes - FJS pipelines now green.

+1 RTBC

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Let's see if we can add a test to prevent this happening again.

catch’s picture

catch
he/him
Primary language English
commented

I think that is probably #3612498: PhpUnitApiFindAllClassFilesTest not finding namespace errors ?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Added a test over there that finds this and one other case.

godotislate’s picture

godotislate
he/him
commented

Should we fix NodeSearchTest either here or in #3612498: PhpUnitApiFindAllClassFilesTest not finding namespace errors as well?

Issue is that the namespace in the file is Drupal\Tests\search_node\Kernel\node: https://git.drupalcode.org/project/drupal/-/blob/main/core/modules/searc...

But the file location is core/modules/search/modules/search_node/tests/src/node/Kernel/NodeSearchTest.php

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I think fix that over there as we first found it there and also it's a useful test to prove the new test works.

  • catch committed b09c82da on main 
    fix: #3619402 Fix olivero AjaxTest directory

By: acbramley
By: longwave
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.