Problem/Motivation

Found more tests using search

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3618672

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !16815

quietone’s picture

quietone commented
Title: Move tests for SearchQuery and ViewsSearchQuery » Move tests to deprecate Search
Issue summary: View changes
Status: Active » Needs review
dcam’s picture

dcam commented

core/modules/search/tests/src/Kernel/Database/ConnectionTest.php is a Unit test, but it's in the Kernel test directory. Was that accidental?

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Don't think it would cause a failure as the namespace matches but nice catch @dcam.

quietone’s picture

quietone commented
Status: Needs work » Needs review

Thanks folks.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

The original test classes no longer have any references to the Search module. The moved functions are all appropriate. And the tests are passing. This looks good to me.

  • catch committed 7670ba1c on main 
    task: #3618672 Move tests to deprecate Search

By: quietone
By: dcam

  • catch committed 2b806141 on 11.x 
    task: #3618672 Move tests to deprecate Search

By: quietone
By: dcam
(...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.