Problem/Motivation

Olivero uses in core/tests and core/profiles

$ git grep -lwi olivero | grep -v core/themes/olivero | grep core/tests
core/tests/Drupal/BuildTests/Command/GenerateThemeTest.php
core/tests/Drupal/FunctionalTests/Installer/DistributionProfileExistingSettingsTest.php
core/tests/Drupal/FunctionalTests/Installer/StandardInstallerTest.php
core/tests/Drupal/KernelTests/Core/Theme/ThemeInstallerTest.php
core/tests/Drupal/Nightwatch/Tests/a11yTestDefault.js
core/tests/Drupal/TestSite/TestSiteClaroInstallTestScript.php
core/tests/Drupal/Tests/WebAssert.php
$ git grep -lwi olivero | grep -v core/themes/olivero | grep core/profiles
core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php
core/profiles/tests/nightwatch_a11y_testing/config/install/system.theme.yml
core/profiles/tests/nightwatch_a11y_testing/nightwatch_a11y_testing.info.yml

core/tests/Drupal/TestSite/TestSiteClaroInstallTestScript.php is addressed in sibling issue, #3618256: Adjust tests using olivero_test test module

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3618449

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented

Maybe this should be for all Nightwatch tests.

quietone opened merge request !16791

quietone’s picture

quietone commented
Status: Active » Needs work
quietone’s picture

quietone commented
Title: Change a11y tests using Olivero » Change uses of Olivers in core/tests and core/profiles
Issue summary: View changes
quietone’s picture

quietone commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Change uses of Olivers in core/tests and core/profiles » Change uses of Olivero in core/tests and core/profiles
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I went over the MR changes a few times and didn't see anything to comment about. The changes look good to me.

I also grepped core/tests and core/profiles for "olivero" and didn't find any instances that were missed by the MR. As noted in the issue summary, the use of olivero_test in TestSiteClaroInstallTestScript will be handled elsewhere.

gábor hojtsy made their first commit to this issue’s fork.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +11.5.0 release priority

Agree the MR looks good.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work

Actually coming back here from #3617523: Remove Olivero from comments and I made up my mind about new introductions of Claro, can we not do that at this stage? :)

quietone’s picture

quietone commented
Status: Needs work » Needs review

I agree that using Claro isn't ideal. It is used only when the test fails when using Stark or a the 'Test Theme'. Stark does not provide all the features that Claro does. I've used it in the scope of this issue which is to deprecate Olivero.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

I think its double the work if we need to do it again, but if this helps us get Olivero removed fast, then we can also do that.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work

Gitlab UI hasn't updated yet, but there's a merge conflict in core/tests/Drupal/FunctionalTests/Installer/DistributionProfileExistingSettingsTest.php with #3617584: Change tests using Olivero committed to main.

quietone’s picture

quietone commented
Status: Needs work » Needs review

Rebased

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

There weren't any problems with the rebase so I am restoring the RTBC

  • godotislate committed 8a170664 on main 
    task: #3618449 Change uses of Olivero in core/tests and core/profiles...

  • godotislate committed 1af3e987 on 11.x 
    task: #3618449 Change uses of Olivero in core/tests and core/profiles...
godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8a17066 to main and 1af3e98 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.