Problem/Motivation

Tests are using an 'olivero_test' module.

Steps to reproduce

Proposed resolution

Decide how to adjust these tests so Olivero can be deprecated
Create stark_test

  • core/modules/comment/tests/src/Functional/CommentPreviewTest.php
  • core/modules/system/tests/src/Functional/Menu/BreadcrumbTest.php

Per #12 ignore core/modules/search/tests/src/Nightwatch/Tests/Olivero/TestSiteOliveroInstallTestScript.php since Search is being removed.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 3618256-nr-bot_09rkouqe.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3618256

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes

quietone opened merge request !16790

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs work

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented

Pushed up some changes

1. Did some tweaks to stark_test to not use olivero still
2. There's a preprocessComment in Olivero which was breaking core/modules/comment/tests/src/Functional/CommentPreviewTest.php but we aren't really testing that but more that the comment posts
3. Added preprocessMenu to stark_test because Olivero had a template that added that class which base menu twig did not.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

I found a few things and left comments on the MR. There are a couple of changes that I think need to be made and one question that I had.

quietone’s picture

quietone commented

I have applied the 3 suggestions. As for FormTestUrlForm, I don't know. I have pinged @smustgrave in #core-development about this.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
dcam’s picture

dcam commented

Thank you for taking another look, @smustgrave.

Of the four remaining tasks in the issue summary it looks like two are still relevant:

  • core/modules/search/tests/src/Nightwatch/Tests/Olivero/TestSiteOliveroInstallTestScript.php
  • core/tests/Drupal/TestSite/TestSiteClaroInstallTestScript.php

Should the status be Needs Work for these to be updated?

smustgrave’s picture

smustgrave commented

core/modules/search/tests/src/Nightwatch/Tests/Olivero/TestSiteOliveroInstallTestScript.php maybe not since search is also being removed

Pushed a change for TestSiteClaroInstallTestScript

dcam’s picture

dcam commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Ok. I'm updating the IS to reflect that.

The latest changes look good to me. I searched for other uses of olivero_test and didn't come up with any. Let's send it up.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3618256-nr-bot_09rkouqe.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Test failures were random

  • catch committed 0263bee5 on main 
    task: #3618256 Adjust tests using olivero_test test module

By: quietone...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to main, thanks!

Not sure if we need to backport this to 11.x but moving there just in case.

smustgrave opened merge request !17061

smustgrave’s picture

smustgrave commented
Status: Patch (to be ported) » Reviewed & tested by the community

Don't believe that nightwatch failure is related.

We backported other olivero test tickets so assume we have to here too

  • catch committed a776fda6 on 11.x 
    task: #3618256 Adjust tests using olivero_test test module

By: quietone...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Re-ran the nightwatch test and all green.

Committed/pushed to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.