Problem/Motivation

PHPUnit 12 flags 129 "No expectations configured for the mock object" notices plus 3 incomplete tests, so the next-major job stays red. Test-only debt split out of #3617205: Add native return types and fix remaining PHP 8.5 deprecations.

Issue fork external_entities-3617932

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

velmir_taky created an issue. See original summary.

velmir_taky opened merge request !143

velmir_taky’s picture

velmir_taky commented
Status: Active » Needs review

Switched expectation-less doubles to createStub(), kept mocks only where a test asserts calls.

Instead of just dropping the markTestIncomplete(), the two functional tests now assert real behaviour (parsed REST params + file edit round-trip); the empty ViewsData placeholder became a real base-table test.

guignonv’s picture

guignonv
Primary language French
Location Montpellier
commented
Assigned: Unassigned » velmir_taky
Status: Needs review » Reviewed & tested by the community

Excellent work. You cleaned up the use of doubles. Indeed, mocks were overused. Thanks!

velmir_taky’s picture

velmir_taky commented
Assigned: velmir_taky » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks @guignonv!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.