Problem/Motivation
This is a fairly standard light mode disabled checkbox:

Disabled checkbox in dark mode:

You can't differentiate visually between the disabled or enabled checkbox.
Steps to reproduce
- Go to /admin/modules/uninstall
- Switch between light/dark mode
- Confirm that it is difficult to see disabled elements
Proposed resolution
Add the CSS to make this stand out better.
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3617875-disabled-elements-dark-mode.patch | 4.77 KB | mgifford |
| #3 | Dark-alternative.png | 47.84 KB | mgifford |
| #3 | Light-alternative.png | 46.6 KB | mgifford |
| Dark-disabled.png | 50.17 KB | mgifford | |
| Light-disabled.png | 52.06 KB | mgifford |
Issue fork drupal-3617875
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mgiffordDisabled controls are legitimate HTML, and poorly styled disabled controls will remain a Drupal accessibility problem.
Comment #3
mgiffordI'm not sure this is the best approach, but worth putting it out for consideration.
Comment #4
mgiffordThe red line on black probably doesn't meet color contrast....
Comment #5
mherchelIt's also not the right size 🤷♂️
Comment #6
mgiffordI failed to create a MR again, so just uploaded this patch. I may have luck with GitLab tomorrow.