Problem/Motivation

First on scaffold panel, could be on canvas and/or navigator.

A good idea on top of each form (config, styles,...) to ease this part for a builder.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 styles_hover.jpg35.15 KBmogtofu33

Issue fork display_builder-3616791

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mogtofu33 created an issue. See original summary.

mogtofu33’s picture

mogtofu33 commented
Issue summary: View changes

mogtofu33 opened merge request !359

mogtofu33’s picture

mogtofu33 commented
Status: Needs work » Needs review
Related issues: +#3616763: Add settingsSummary() to the ui_styles_attributes source plugin

Can be merged when #3616763: Add settingsSummary() to the ui_styles_attributes source plugin is merged and released in UI Styles.

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » pdureau
StatusFileSize
new styles_hover.jpg35.15 KB

Here is a visual result:

Example styles

Note: review need the ui_styles patch:

        "patches": {
            "drupal/ui_styles": {
                "https://drupal.org/i/3616763 settings summary for the ui_styles_attributes source": "https://git.drupalcode.org/project/ui_styles/-/merge_requests/100.patch"
            }
        }
mogtofu33’s picture

mogtofu33 commented
Assigned: pdureau » mogtofu33
Status: Needs review » Needs work
mogtofu33’s picture

mogtofu33 commented
Issue tags: +display_builder-1.0.0-beta8
mogtofu33’s picture

mogtofu33 commented
Issue tags: +UX
mogtofu33’s picture

mogtofu33 commented
Status: Needs work » Needs review
Issue tags: -display_builder-1.0.0-beta8 +display_builder-1.0.0-beta7

UI Styles is merged, but wait for release.

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » pdureau

UI Styles released, rebased and good for review.

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs review » Reviewed & tested by the community

Feature review

I love that

  • those indicators are icons instead of colored dotes
  • clicking on a icon is acting in the contextual panels: (opening, closing, switching the tab)

Am I understanding well?

  • PluginSettingsInterface::settingsSummary() for sources are printed after the label at the start of the .db-layer
  • Except for ComponentSource where the summary is printed in a little icon a the end of the .db-layer
  • Islands implementing ThirdPartySettingsInterface have also their icons at the end, one by panel

It is a bit unexpected ComponentSource is working differently but if it is a assumed and documented choice, I am OK with that.

Also, FIY, UI Patterns is currently adding, and sometimes altering, some PluginSettingsInterface::settingsSummary() implementation in #3528205: Performance: On-demand lazy-loading source selector. It seems it will make this change even more helpful, but don't hesitate to share your needs or warnings there if needed.

Code review

OK for me but I don't understand why src/Plugin/display_builder/Island/ScaffoldOptions.php is marked as "added" in the MR. We already add this island before, didn't we?

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Reviewed & tested by the community » Fixed

ScaffoldOptions has been removed previously by mistake.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • mogtofu33 committed 7f380bc6 on 1.0.x 
    task: #3616791 Implement visual settings summary

By: mogtofu33
By:...