Problem/Motivation

Refactor settingsSummary based on comment: https://www.drupal.org/project/ui_patterns/issues/3568363#comment-16451975

To work with UI Styles it requires this work: #3616763: Add settingsSummary() to the ui_styles_attributes source plugin

Proposed resolution

Add a collector, move the summary to source component.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork display_builder-3616786

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mogtofu33 created an issue. See original summary.

mogtofu33 opened merge request !345

mogtofu33’s picture

mogtofu33 commented
Issue summary: View changes
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » pdureau
Status: Active » Needs review
Issue tags: +display_builder-1.0.0-beta7
mogtofu33’s picture

mogtofu33 commented

There will be a follow-up for the UI. This code part is then easier to review.

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs review » Reviewed & tested by the community

So, a SummaryCollector service has been added to collect summaries from source's ThirdPartySettingsInterface implementations, moving the UI Styles related logic from ComponentSource and ScaffoldPanel to this service, while removing the UI Styles hardcoded logic.

That's cool.

By focusing on third_party_settings and not addressing the::settingsSummary() in component sources generated by aggregating the ::settingsSummary() of prop sources , this change is distinct from UI Patterns's #3568363: Add settings form values to the component settingsSummary(). and the quoted comment.

That's fine because third_party_settings is specific to Display Builder (and will stay like that) but prop sources management is shared with UI Patterns.

So, RTBC.

  • mogtofu33 committed a0cefddd on 1.0.x 
    task: #3616786 SummaryCollector for settings aggregation and update...
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.