Problem/Motivation

Let's use an OOP approach to manage comment notifications.
I think it would be better to move comment_notify into a separate entity, but for now let's just use the service.

Issue fork comment_notify-3616719

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

igor mashevskyi created an issue. See original summary.

igor mashevskyi’s picture

igor mashevskyi commented
Assigned: igor mashevskyi » Unassigned
Status: Active » Needs review

igor mashevskyi opened merge request !29

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs review » Needs work

Thanks for working on this. The storage-service direction looks good, but MR !29 now conflicts with the recently merged #3616715.

Please rebase onto the latest 8.x-1.x

igor mashevskyi’s picture

igor mashevskyi commented
Status: Needs work » Needs review
gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs review » Needs work

This is looking great!!!

Just two small nits and this should be good to go.

Thanks!!!

igor mashevskyi’s picture

igor mashevskyi commented
Status: Needs work » Needs review
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Move comment_notify.inc functions to separete service » Move comment_notify.inc functions to separate service

(nothing helpful to say, just wanted to fix the title typo)

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.