Problem/Motivation

Implement OOP hooks for better OOP & DI support, instead of having all hook logic in the module file.

Proposed resolution

Convert hook implementations to OOP hooks, with backwards compatibility.
See https://www.drupal.org/node/3442349

Issue fork comment_notify-3616715

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

igor mashevskyi created an issue. See original summary.

igor mashevskyi opened merge request !27

igor mashevskyi’s picture

igor mashevskyi commented
Assigned: igor mashevskyi » Unassigned
Status: Active » Needs review
gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs review » Needs work

Can you please resolve the failing PHPCS job and rerun the pipeline?

https://git.drupalcode.org/issue/comment_notify-3616715/-/jobs/11604650

Thanks.

igor mashevskyi’s picture

igor mashevskyi commented
Status: Needs work » Needs review

Fixed

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs review » Needs work
igor mashevskyi’s picture

igor mashevskyi commented
Status: Needs work » Needs review

#gnuget I've corrected the code according to your comments. Can you please check the changes again?

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs review » Needs work

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.