Problem/Motivation

On Drupal 11.3, taxonomy term ordering cannot be saved when Revision Manager is enabled.

Drupal 11.3 changed the taxonomy vocabulary overview into an entity form. Revision Manager consequently alters the overview form, displays its revision settings, and adds its own submit callback to the Save button. This replaces the taxonomy overview form's normal submit handling, so submitted term weights are not persisted.

This is another instance of the compatibility problem described in Drupal core issue #3564792.

Steps to reproduce

  1. Install Drupal 11.3 and Revision Manager 1.0.0-beta5.
  2. Create a taxonomy vocabulary with multiple terms.
  3. Open /admin/structure/taxonomy/manage/VOCABULARY/overview.
  4. Reorder the terms using drag-and-drop or row weights.
  5. Save the form.

Expected result: The new term order is saved.

Actual result: The previous order remains. Revision Manager settings are also displayed on the taxonomy overview form.

Proposed resolution

Exclude the overview entity-form operation from Revision Manager's form alteration, as already done for operations such as delete, cancel, and reset.

The issue fork merge request !14 adds overview to the disallowed operations in src/Form/FormHelper.php.

Remaining tasks

  • Review and test the patch.
  • Commit the fix and include it in a Revision Manager release.

User interface changes

Revision Manager settings are no longer displayed on taxonomy vocabulary overview forms. Taxonomy term ordering can be saved normally.

API changes

None.

Data model changes

None.

Validation

Tested with Drupal 11.3.12 and Revision Manager 1.0.0-beta5:

  • Revision Manager settings no longer appear on taxonomy overview forms.
  • Changed taxonomy weights persist after saving.
  • The changed order remains after reloading the page.

Related issues

Issue fork revision_manager-3616079

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hanan alasari created an issue. See original summary.

hanan alasari opened merge request !14

hanan alasari’s picture

hanan alasari
Primary language English
Location kassel
commented
Issue summary: View changes
hanan alasari’s picture

hanan alasari
Primary language English
Location kassel
commented
Status: Active » Needs review
vinodhini.e’s picture

vinodhini.e commented

Hi,

Tested on Drupal 11.3.11 with Revision Manager 1.0.0-beta5.
Created a taxonomy vocabulary and added multiple terms.
Navigated to the vocabulary overview page and reordered the terms using drag-and-drop.
Also modified the row weights and saved the form.
Verified the term order after saving and refreshed the page multiple times.
The reordered terms persisted successfully after each save and page refresh.
I was unable to reproduce the reported issue.
Are there any additional steps or specific configuration requirements needed to reproduce this issue?

j-barnes’s picture

j-barnes commented

Confirmed on 11.3.16. Saw the Revision Manager details element getting added to the term overview page and was able to replicate the ordering not saving.

@vinodhini.e - thanks for testing this! I think the difference might just be that the taxonomy term entity type needs enabling at /admin/config/content/revision-manager first. Without that the alter never fires, so the form behaves normally.

Thanks @hanan alasari!

j-barnes’s picture

j-barnes commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.