There currently is no test for the "Hide link to home page if it's the only breadcrumb item" (HIDE_SINGLE_HOME_ITEM) config.

Issue fork easy_breadcrumb-3616002

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

loopduplicate created an issue. See original summary.

loopduplicate opened merge request !217

loopduplicate’s picture

loopduplicate commented
Assigned: loopduplicate » Unassigned
Status: Active » Needs review
Issue tags: -Needs test

greg boggs made their first commit to this issue’s fork.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

I added an extra test to also ensure the setting did not affect subpage breadcrumbs. I couldn't get tests to run locally, even with AI trying to assist me, so I'll wait and see what the tests say.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Hrm, not sure how I mucked up so many merge commits here. This is hard. I think if we squash on merge and edit the commit message, it should all work out. Will wait for you to take a look at my bad git fu.

loopduplicate’s picture

loopduplicate commented
Assigned: Unassigned » loopduplicate

I'll take a look now and probably create a new branch based on current 2.x and cherry pick your commits onto it... my git fu is pretty good :3

loopduplicate opened merge request !223

loopduplicate changed the visibility of the branch 3616002-test-single-home-item to hidden.

loopduplicate’s picture

loopduplicate commented
Assigned: loopduplicate » Unassigned
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: Unassigned » csakiistvan
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: csakiistvan » Unassigned
Status: Needs review » Reviewed & tested by the community

✅ Tested and works — MR !223.

Kept short on purpose — happy to share more detail (logs, exact config, extra cases) if anyone needs it.

loopduplicate’s picture

loopduplicate commented
Status: Reviewed & tested by the community » Needs review

@csakiistvan, wrong issue

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented

@loopduplicate comment updated based on our latest guides :)

loopduplicate’s picture

loopduplicate commented

@csakiistvan
This is not an acceptable review. I think maybe you need to slow down a bit.

"✅ Tested and works — MR !223.

Kept short on purpose — happy to share more detail (logs, exact config, extra cases) if anyone needs it."

  • loopduplicate committed 207dd062 on 2.x 
    Issue: #3616002 Create test for HIDE_SINGLE_HOME_ITEM config

By:...
loopduplicate’s picture

loopduplicate commented

@csakiistvan, what I meant in #15 is that when you edited your comment, now all it says it that you tested it and it works. What would be the best, is if the comment matched what is in the Drupal documentation for reviewing a merge request, notably, "detailed step" 13 on that page, which starts with "After finishing your reviewing and testing, [...]".

loopduplicate’s picture

loopduplicate commented
Status: Needs review » Fixed

Thank you, @csakiistvan and @greg-boggs.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.