Problem/Motivation

Our modal renders <h1 class="fr-modal__title"> while upstream uses <h2> (checked in the 1.14.4 and 1.15.1 examples: modal, transcription, theme modal). A modal should not add a second h1 to the page. Spotted while working on #3615328.

Proposed resolution

Add a title_tag prop to the modal component, default h2, same approach as summary. Typography does not change (fr-modal__title is styled by class), only the document outline moves. Sites relying on the h1 can set title_tag: h1.

Worth a line in the release notes.

Issue fork ui_suite_dsfr-3615748

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

just_like_good_vibes created an issue. See original summary.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: Unassigned » just_like_good_vibes

just_like_good_vibes opened merge request !215

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.