Problem/Motivation

🐛 Remplace la balise dialog par une balise div, le rĂŽle dialog est ajoutĂ© automatiquement Ă  l'ouverture de la modale #1478

Upstream keeps <dialog> for regular modals but the transcription's embedded modal is now <div class="fr-modal"> (role set by JS on open). Our transcription.twig composes ui_suite_dsfr:modal, which hardcodes <dialog> with role/aria-modal.

Proposed resolution

We could add a tag prop to the modal component (dialog by default) that also drops role/aria-modal when set to div, and use it from transcription.

The modal title part (#1465) is already fine, transcription already passes a title to the modal.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

just_like_good_vibes created an issue. See original summary.

just_like_good_vibes’s picture

Assigned: Unassigned » just_like_good_vibes

just_like_good_vibes’s picture

Assigned: just_like_good_vibes » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.