Issues reported by phpstan [#3615609]

Problem/Motivation

 ------ --------------------------------------------------------------------- 
  Line   src/EventSubscriber/UserContactMappingSubscriber.php                 
 ------ --------------------------------------------------------------------- 
  55     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  56     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Form/ListBuilderForm.php                                           
 ------ ----------------------------------------------------------------------- 
  34     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/ListBuilder/ContactListBuilder.php                                 
 ------ ----------------------------------------------------------------------- 
  39     Direct injection of entity storage via $storage is not recommended.    
         Inject Drupal\Core\Entity\EntityTypeManagerInterface and call          
         getStorage() at the call-site instead.                                 
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
  40     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
  41     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
  42     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/ListBuilder/ContactMethodListBuilder.php                           
 ------ ----------------------------------------------------------------------- 
  38     Direct injection of entity storage via $storage is not recommended.    
         Inject Drupal\Core\Entity\EntityTypeManagerInterface and call          
         getStorage() at the call-site instead.                                 
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
  39     Direct injection of entity storage via $contactStorage is not          
         recommended. Inject Drupal\Core\Entity\EntityTypeManagerInterface and  
         call getStorage() at the call-site instead.                            
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
  39     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
  40     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
  41     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
  249    Method                                                                 
         Drupal\crm\ListBuilder\ContactMethodListBuilder::getDefaultOperations  
         () is missing the CacheableMetadata parameter added in Drupal 11.3.    
         Update the signature to:                                               
         getDefaultOperations(\Drupal\Core\Entity\EntityInterface $entity,      
         ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL).           
         🪪  drupal.entityListBuilderMissingCacheabilityParameter               
         💡  See https://www.drupal.org/node/3533080                            
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/ListBuilder/ContactMethodTypeListBuilder.php                       
 ------ ----------------------------------------------------------------------- 
  63     Method                                                                 
         Drupal\crm\ListBuilder\ContactMethodTypeListBuilder::getDefaultOperat  
         ions() is missing the CacheableMetadata parameter added in Drupal      
         11.3. Update the signature to:                                         
         getDefaultOperations(\Drupal\Core\Entity\EntityInterface $entity,      
         ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL).           
         🪪  drupal.entityListBuilderMissingCacheabilityParameter               
         💡  See https://www.drupal.org/node/3533080                            
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/ListBuilder/ContactTypeListBuilder.php                             
 ------ ----------------------------------------------------------------------- 
  61     Method                                                                 
         Drupal\crm\ListBuilder\ContactTypeListBuilder::getDefaultOperations()  
         is missing the CacheableMetadata parameter added in Drupal 11.3.       
         Update the signature to:                                               
         getDefaultOperations(\Drupal\Core\Entity\EntityInterface $entity,      
         ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL).           
         🪪  drupal.entityListBuilderMissingCacheabilityParameter               
         💡  See https://www.drupal.org/node/3533080                            
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/ListBuilder/MethodDetailListBuilder.php                            
 ------ ----------------------------------------------------------------------- 
  37     Direct injection of entity storage via $contactMethodTypeStorage is    
         not recommended. Inject Drupal\Core\Entity\EntityTypeManagerInterface  
         and call getStorage() at the call-site instead.                        
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
  37     Direct injection of entity storage via $storage is not recommended.    
         Inject Drupal\Core\Entity\EntityTypeManagerInterface and call          
         getStorage() at the call-site instead.                                 
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/ListBuilder/RelationshipListBuilder.php                            
 ------ ----------------------------------------------------------------------- 
  41     Direct injection of entity storage via $storage is not recommended.    
         Inject Drupal\Core\Entity\EntityTypeManagerInterface and call          
         getStorage() at the call-site instead.                                 
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
  42     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
  43     Direct injection of entity storage via $contactStorage is not          
         recommended. Inject Drupal\Core\Entity\EntityTypeManagerInterface and  
         call getStorage() at the call-site instead.                            
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
  43     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
  44     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
  45     Read-only properties are incompatible with                             
         Drupal\Core\DependencyInjection\DependencySerializationTrait when the  
         trait is used by a parent class on PHP < 8.4.                          
         🪪  dependencySerializationTraitProperty.unsupportedReadOnlyProperty   
         💡                                                                     
         Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeu  
         p() cannot initialize a read-only property declared in a child class.  
         Use the trait in this class directly, or remove the readonly           
         modifier.                                                              
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/ListBuilder/RelationshipTypeListBuilder.php                        
 ------ ----------------------------------------------------------------------- 
  61     Method                                                                 
         Drupal\crm\ListBuilder\RelationshipTypeListBuilder::getDefaultOperati  
         ons() is missing the CacheableMetadata parameter added in Drupal       
         11.3. Update the signature to:                                         
         getDefaultOperations(\Drupal\Core\Entity\EntityInterface $entity,      
         ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL).           
         🪪  drupal.entityListBuilderMissingCacheabilityParameter               
         💡  See https://www.drupal.org/node/3533080                            
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/ListBuilder/UserContactMappingListBuilder.php                      
 ------ ----------------------------------------------------------------------- 
  35     Direct injection of entity storage via $storage is not recommended.    
         Inject Drupal\Core\Entity\EntityTypeManagerInterface and call          
         getStorage() at the call-site instead.                                 
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
  101    Method                                                                 
         Drupal\crm\ListBuilder\UserContactMappingListBuilder::getDefaultOpera  
         tions() is missing the CacheableMetadata parameter added in Drupal     
         11.3. Update the signature to:                                         
         getDefaultOperations(\Drupal\Core\Entity\EntityInterface $entity,      
         ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL).           
         🪪  drupal.entityListBuilderMissingCacheabilityParameter               
         💡  See https://www.drupal.org/node/3533080                            
 ------ ----------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/Service/RelationshipService.php                                  
 ------ --------------------------------------------------------------------- 
  27     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/Service/UserContactMappingService.php                            
 ------ --------------------------------------------------------------------- 
  62     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  63     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  64     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Functional/ContactEditFormTest.php                         
 ------ --------------------------------------------------------------------- 
  70     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/Entity/ContactMethodTypeTest.php                    
 ------ --------------------------------------------------------------------- 
  71     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/Entity/ContactTest.php                              
 ------ --------------------------------------------------------------------- 
  64     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/Entity/ContactTypeTest.php                          
 ------ --------------------------------------------------------------------- 
  72     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/Entity/RelationshipTest.php                         
 ------ --------------------------------------------------------------------- 
  70     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/Form/ContactFormTest.php                            
 ------ --------------------------------------------------------------------- 
  82     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/Form/ContactMethodTypeFormTest.php                  
 ------ --------------------------------------------------------------------- 
  77     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/Form/MethodDetailFormTest.php                       
 ------ --------------------------------------------------------------------- 
  85     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  86     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/Form/RelationshipFormTest.php                       
 ------ --------------------------------------------------------------------- 
  99     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  100    Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  101    Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/Form/RelationshipTypeFormTest.php                   
 ------ --------------------------------------------------------------------- 
  79     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   tests/src/Kernel/PostUpdateAddFieldMappingsSettingTest.php             
 ------ ----------------------------------------------------------------------- 
  63     Avoid calling Symfony\Component\Yaml\Yaml::parse() directly. Use       
         \Drupal\Component\Serialization\Yaml::decode() instead, which handles  
         exceptions consistently and applies the correct parse flags.           
         🪪  drupal.symfonyYamlParse                                            
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   tests/src/Kernel/PostUpdateAddFireEventUserInsertSettingTest.php       
 ------ ----------------------------------------------------------------------- 
  70     Avoid calling Symfony\Component\Yaml\Yaml::parse() directly. Use       
         \Drupal\Component\Serialization\Yaml::decode() instead, which handles  
         exceptions consistently and applies the correct parse flags.           
         🪪  drupal.symfonyYamlParse                                            
 ------ ----------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/Form/ContactTypeFormTest.php                          
 ------ --------------------------------------------------------------------- 
  86     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/Form/MethodDetailFormTest.php                         
 ------ --------------------------------------------------------------------- 
  85     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/Form/RelationshipFormTest.php                         
 ------ --------------------------------------------------------------------- 
  121    Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/ListBuilder/ContactListBuilderTest.php                
 ------ --------------------------------------------------------------------- 
  89     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/ListBuilder/ContactMethodListBuilderTest.php          
 ------ --------------------------------------------------------------------- 
  93     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  94     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/ListBuilder/ContactMethodTypeListBuilderTest.php      
 ------ --------------------------------------------------------------------- 
  70     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/ListBuilder/ContactTypeListBuilderTest.php            
 ------ --------------------------------------------------------------------- 
  69     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/ListBuilder/RelationshipListBuilderTest.php           
 ------ --------------------------------------------------------------------- 
  97     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  100    Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/ListBuilder/RelationshipTypeListBuilderTest.php       
 ------ --------------------------------------------------------------------- 
  70     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/ListBuilder/UserContactMappingListBuilderTest.php     
 ------ --------------------------------------------------------------------- 
  92     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/Service/RelationshipServiceTest.php                   
 ------ --------------------------------------------------------------------- 
  52     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Unit/Service/UserContactMappingServiceTest.php             
 ------ --------------------------------------------------------------------- 
  79     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  80     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  81     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 [ERROR] Found 61 errors
Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork crm-3615609

Show commands
Start within a Git clone of the project using the version control instructions.
Add & fetch this issue fork’s repository
Or, if you do not have SSH keys set up on git.drupalcode.org:
Add & fetch this issue fork’s repository
3615609-issues-reported-by changes, plain diff MR !257
Check out this branch for the first time

Check out existing branch, if you already have it locally
About issue forks
Comments

Comment #1

8 August 2026 at 16:56
bluegeek9 created an issue. See original summary.
Comment #2

9 August 2026 at 05:58
yusuf_khan made their first commit to this issue’s fork.
Comment #3

yusuf_khan commented 9 August 2026 at 05:59
Status:
Active
» Needs review
@bluegeek9
Phpstan issues has been fixed . Please review my MR.
Comment #4

9 August 2026 at 05:59
yusuf_khan opened merge request !257
Comment #5

bluegeek9 commented 9 August 2026 at 12:51
Status:
Needs review
» Active
@yusuf_khan,
You code fails the pipeline.
I have reverted all your code.
Comment #6

bluegeek9 commented 9 August 2026 at 20:36
Assigned:	bluegeek9	» Unassigned
Status:	Active	» Needs review
Comment #7

10 August 2026 at 14:37
bluegeek9 committed 26e3fcd6 on 1.0.x authored by yusuf_khan
```
Resolve #3615609 "Issues reported by"
```
Comment #8

bluegeek9 commented 10 August 2026 at 14:40
Status:
Needs review
» Fixed

	Thank you for your contribution! Your continued support makes this project sustainable.

There are multiple ways to show appreciation for the work contributed to this project including: Triage issues and adding more context to existing issues. Flagging CRM as a favorite on the project page to help others discover it and show your support. Review the Developer Docs for accuracy and clarity.
Comment #9

10 August 2026 at 14:40
Now that this issue is closed, review the contribution record.
As a contributor, attribute any organization that helped you, or if you volunteered your own time.
Maintainers, credit people who helped resolve this issue.
Comment #10

24 August 2026 at 14:45
Status:
Fixed
» Closed (fixed)
Automatically closed - issue fixed for 2 weeks with no activity.
Issues reported by phpstan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork crm-3615609

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

News items

Our community

Documentation

Drupal code base

Governance of community
