Problem/Motivation

🐛 DĂ©sactive le composant quand l'attribut HTML data-fr-scheme est absent et corrige la marge en bas de la modale de sĂ©lection du thĂšme #1434

Since 1.15, dsfr.module.js disables the display component (fieldset rendered disabled) when <html> has no data-fr-scheme attribute. All upstream examples switched from data-fr-theme to data-fr-scheme.

The theme never emits data-fr-scheme by itself: only ui_skins sets it (ui_suite_dsfr.ui_skins.themes.yml), and only when a skin is selected. So after the library update the theme settings modal is disabled out of the box.

Proposed resolution

We could emit data-fr-scheme="system" on <html> by default (preprocess_html) and let ui_skins override it as today.

Issue fork ui_suite_dsfr-3615322

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

just_like_good_vibes created an issue. See original summary.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Issue summary: View changes
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Issue summary: View changes
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: Unassigned » just_like_good_vibes

just_like_good_vibes opened merge request !210

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.