Fix problems described in this comment: https://www.drupal.org/project/projectapplications/issues/3608209#commen...

Reviewed 1.0.x (commit 3f7c696) on Drupal 10.3/11.

AUTOMATED REVIEW

phpcs (Drupal + DrupalPractice) is clean on the PHP/YAML. The remaining violations are in JS / build files:
- assets/js/simpleParallax.js: 6 errors — a lowercase "false" that should be "FALSE" (Drupal JS standard), and missing spaces around a ternary "?" (lines 17-19). This is your own behavior file, so please run it through the Drupal JS standards / prettier.
- vite.config.js: 3 errors (ternary spacing).
- dist/js/simpleParallax.js: flagged as minified.

Suggestion: add a phpcs.xml.dist that excludes build output (dist/) and tooling (vite.config.js), and fix assets/js so phpcs is green on the code you actually maintain.

MANUAL REVIEW — POSITIVES

- The single \Drupal::entityTypeManager() call is inside the static isApplicable() method, where service injection isn't available — this is the accepted core pattern, not an issue.
- No raw SQL and no unsafe output. core_version_requirement ^10.3 || ^11 || ^12, and no hardcoded version/project keys in the .info.yml.

SUGGESTIONS

- The release currently ships build tooling (package.json, package-lock.json, vite.config.js) and a compiled dist/. Consider whether these belong in the packaged release, or add a .gitattributes with export-ignore for the toolchain.
- The bundled simpleParallax.js third-party library should have its version and license documented (Drupal third-party asset policy).
- No automated tests yet — not required for coverage, but a small Kernel/FunctionalJavascript test would strengthen the module.

Good, focused module. Mainly needs the JS coding-standards cleanup and a decision on what to ship in the release.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

o_timoshchuk created an issue. See original summary.

o_timoshchuk’s picture

Assigned: o_timoshchuk » Unassigned
Status: Active » Needs review

o_timoshchuk’s picture

Status: Needs review » Fixed

Merged

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.