Problem/Motivation

When using Display Builder in a real world case like with Display Builder Bootstrap recipe, I discovered a pain point.

The recipe use Page Layout and Entity view with Field formatter -> Rendered entity. Perhaps it's not the 'common use case' but seems a good way.

Problem is when on preview we see rendered entity with a display but we cannot edit it directly. Need to go to admin/structure/display-builder/instances and find the instances to edit it.

An other issue is if you open multiple tabs display, to know clearly which one you are editing.

Steps to reproduce

Proposed resolution

  • Integrate Drupal contextual menu (edit) with link to display, so we can access from preview (probably good approach)
  • Add a sidebar panel of the instances list with link to instances (complementary)
  • Add the instance id somewhere, perhaps in the help menu?

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 experimental_island_instances.jpg89.42 KBmogtofu33

Issue fork display_builder-3613587

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mogtofu33 created an issue. See original summary.

mogtofu33’s picture

mogtofu33 commented
Assigned: pdureau » mogtofu33
mogtofu33’s picture

mogtofu33 commented
Issue summary: View changes
pdureau’s picture

pdureau commented

The recipe use Page Layout and Entity view with Field formatter -> Rendered entity. Perhaps it's not the 'common use case' but seems a good way.

This sounds like a legit point.

Problem is when on preview we see rendered entity with a display but we cannot edit it directly.

Not the same formatter, not the same issue, but may be related on a way or the other: #3542276: Embedding a display in an other with a formatter ?

mogtofu33’s picture

mogtofu33 commented
Issue summary: View changes
StatusFileSize
new experimental_island_instances.jpg89.42 KB

I implemented an experimental Island list instances, it's a real helper, to switch display on place, with the preview iframe it makes the building experience easier.

Definitely something to add.

Demo

mogtofu33 opened merge request !323

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » pdureau
Status: Needs work » Needs review

Implemented the islands as it's a quick win.

Let keep the issue open for other options discussion.

mogtofu33’s picture

mogtofu33 commented
Issue tags: +display_builder-1.0.0-beta6
mogtofu33’s picture

mogtofu33 commented
Assigned: pdureau » Unassigned
Status: Needs review » Fixed

The contextual menu is removed with new preview, so not an option on display builder side anymore (but still could be something on the site?).
The current instance id is fixed by instances list island as curent display link.

Closing this one and we can have follow up for UX strategy with related issues.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

pdureau’s picture

pdureau commented

The idea is cool as an optional, opt-in, island.

Some feedback:

  • is "instance" the correct wording here? It is the technical term and the one we use in Admin UI, for site admins, but it may confusing for casual users
  • do we display the instances of the same "buildable" first? only? The list can become long and confusing
  • when we click to a link to an instance, it would be nice to keep the Instance view panel open, so users can see the switch, but if the Instance has a different profile, the Instances view panel may not be activated
mogtofu33’s picture

mogtofu33 commented

Thanks for the feedback, copied in the follow-up issue #3614998: Island instances list navigation enhancement.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.