Fix Spelling issues defined by the pipeline

@adamps made the following comments in the parent issue:

3) I don't necessarily see the need to change UK spelling to US😃.

5) I don't understand why we have 2 files for spelling. If we wish to use a default file from somewhere else, why would we copy it, leading the case where every module is separately maintaining a slightly different file? It says the file is based on core so why not just use that? I feel this project should only maintain a list of words that are strictly relevant specifically to it.

For 3. I originally made changes that allowed for EN-GB by the spell checker. The default .cspell.json we grab from gitlabci defines en-US as the defacto default. As noted in the comment in the description of the that asset, some of the items are expanded in scripts/prepare-cspell.php. You can find this expanded copy as part of the assets you download in the gitlab cspell job (also attached to this task)

I change the language to "en-US,en-GB" and committed it as part of the change so that we will always have the new language.

By default, the CI gives you the option to add a list of words you want to add as "correct" to your project as .cspell_project_words.txt. They even make an assest that you can download directly from the CI so you can easily replace this file with the new words that it finds. This simplifies things for maintainers. So typically, this is the only extra file you ever have to touch.

So for response to 5), I kept both because for the language change I need at least .cspell.json, but opted to keep .cspell_project_words.txt to keep this feature of ease of use.

If preferred I can instead add the list to the "words" property inside of .cspell.json.

#1) We can. What I have though is what we are currently testing against with JUST en-GB enabled. In other words I grabbed what gitlabci is generating for the project and making the single change. That is the only way I know to change the language. I don't know how to "add in" the language to the default without altering the cspell job. What I'm saying is if we didn't want to add in en-gb we wouldn't add a .cspell.json to our project and just have the .cpsell-project-words.txt file.

That said if you are saying you don't care about the defaults that the Drupal community is pulling in I can do that but you will want some of those dictionaries and the like and several of the words like "allowlist vs white/blacklist are cultural indicators that if removed may send the wrong message to people supporting the project.

#2) The second list was like I said, ease of use because the current CI generates lists of all the "wrong" words that you can download over this list making it super easy to maintain. Not that altering a json list is much harder... Just explaining my reasoning. Now that we are creating our own .cspell.json file we can deviate as much as you like including getting rid of the txt.

#3 is an oops from when I got started using the defaults and can reverse those changes.

I can absolutely do that. 👍

adamps,

So everything went well. The only thing that I want to make you aware of is that the word "e-mail" (among a few other words) are set up in the "flagwords" section of the default .cspell.json.

I had to sed the code and replace e-mail with email. Both are considered correct spelling in the English language, but Drupal has made a very opinionated change in #3505522: Miscellaneous CSPELL fixes without any comments as to why. I can only guess for consistency sake. Same with the word "grey" vs "gray".

I ensured that all the automated tests passed after the change as some of them rely on the labeling being identical.