Problem/Motivation

SmsLinkItem is missing all link validation constraints. PHP attributes don't inherit from parent to child class, so SmsLinkItem's #[FieldType] attribute (not re-specifying constraints) silently dropped LinkType/LinkAccess/LinkExternalProtocols/LinkNotExistingInternal — meaning sms_link fields accepted any URI unvalidated, including javascript:.

Proposed resolution

Explicitly re-declare the same constraints core's LinkItem uses.

Comments

ipwa created an issue. See original summary.

  • ipwa committed 14cc646e on 2.0.x 
    fix: #3613093 SmsLinkItem missing link validation constraints

By: ipwa
ipwa’s picture

ipwa commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.