Problem/Motivation

Currently, tests are failing: https://git.drupalcode.org/project/tmgmt/-/pipelines/885001

Proposed resolution

Fix PHPUnit tests.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork tmgmt-3612691

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

claudiu.cristea created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

the phpunit fail could have been a random one, because next minor does not have that. worth looking into sure, but could be tricky to figure out.

however, phpunit now uses 11.4 like next minor did in that pipeline, that's the changes around the body field, we'll need to update demo to ship our own storage for the body field and no longer rely on "body" to get consistent results between all supported core version.

I'd suggest using text_long and not summary, as we don't specifically care about that in demo IIRC and we won't have to touch it when core eventually removes the field type.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

On DDEV, I can replicate consistently the failure with 11.3.x-dev

claudiu.cristea opened merge request !176

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Assigned: claudiu.cristea » Unassigned
Status: Active » Needs review

All PHPUnit tests are green except "phpunit (next minor)", which needs first some fixes in GitLab Templates (see https://git.drupalcode.org/project/gitlab_templates/-/work_items/3572422)

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

I've added the temporary solution mentioned in https://git.drupalcode.org/project/gitlab_templates/-/work_items/3572422 and we have now all PHPUnit tests passing

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Fixed

Thank you for review. Merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

claudiu.cristea opened merge request !177

  • claudiu.cristea committed 370603fe on 8.x-1.x 
    fix: #3612691 Fix PHPUnit tests (followup)

By: claudiu.cristea
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.