Problem/Motivation

When upgrade on Drupal 11 with wsdata 3.0.4, I am encountering this issue :

PHP Fatal error: Declaration of Drupal\wsdata_field\Form\WSFieldAddFieldForm::buildForm(array $form, Drupal\Core\Form\FormStateInterface $form_state, $entity_type_id = null, $bundle = null) must be compatible with Drupal\field_ui\Form\FieldStorageAddForm::buildForm(array $form, Drupal\Core\Form\FormStateInterface $form_state, $entity_type_id = null, $bundle = null, $selected_field_type = null, $display_as_group = 'false')

Steps to reproduce

Upgrade core in drupal 11 and run the command drush updatedb : [warning] Drush command terminated abnormally

CommentFileSizeAuthor
#4 3612034-buildform-signature-compat.patch760 bytesdkmishra

Issue fork wsdata-3612034

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lucuhb created an issue. See original summary.

dkmishra made their first commit to this issue’s fork.

dkmishra opened merge request !12

dkmishra’s picture

dkmishra commented
Version: 3.0.4 » 3.0.x-dev
Status: Active » Needs review
StatusFileSize
new 3612034-buildform-signature-compat.patch760 bytes

Patch attached.

  • 0e54fe10 committed on 3.0.x 
    Issue #3612034: Fixed PHP Fatal error:  Declaration of Drupal\...
spotzero’s picture

spotzero commented
Status: Needs review » Fixed

Looks good, merged.

Thanks a lot!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dkmishra’s picture

dkmishra commented

Hi @spotzero, thanks for committing the fix.

I noticed I wasn't credited for this issue. Would you mind adding issue credit for my contribution if you think it's appropriate?

Thank you!

spotzero’s picture

spotzero commented

Done

dkmishra’s picture

dkmishra commented

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.