Problem/Motivation

Issue #3573315 added some filters on the bootstrap tab and accordion key which now renders it as an underscore instead of a key.

The clean_class filter uses \Drupal\Component\Utility\Html::getClass which calls Html::cleanCssIdentifier to sanitize the key. But this method says "Identifiers cannot start with a digit" which means the numerical tab or accordion key gets replaced with an underscore. That makes all buttons target the same invalid id instead of the expected unique numerical key based ids.

Steps to reproduce

  1. Create a view with a content type and fields
  2. Ensure title is a field and add Body or another field from the content type
  3. Select Bootstrap Tabs and leave it on default settings
  4. Inspect the bootstrap tab buttons in the view preview and see the data-bs-targets all point to the same id ending in an underscore
  5. Save the view, try changing tabs in Bootstrap based theme and see it not working as expected

Proposed resolution

Remove the clean_class twig filter from the accordion and tab twig files.

CommentFileSizeAuthor
#4 views_bootstrap-3611739-remove-clean_class.diff1.42 KBj_s

Issue fork views_bootstrap-3611739

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

j_s created an issue. See original summary.

shelane’s picture

shelane
Primary language English
commented

Or we just prepend it with a valid character? I'll have to think some more on this.

j_s opened merge request !60

j_s’s picture

j_s commented
StatusFileSize
new views_bootstrap-3611739-remove-clean_class.diff1.42 KB

Attaching static diff.

j_s’s picture

j_s commented

Or we just prepend it with a valid character? I'll have to think some more on this.

Yep, that'd work. Feel free to update MR with a different approach. For now, I just needed something to get them working again.

  • shelane committed 8f7c1fa3 on 5.5.x 
    fix: #3611739 Bootstrap tab and accordion keys are broken
shelane’s picture

shelane
Primary language English
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.