Problem/Motivation

No test coverage

Steps to reproduce

Check gitlab CI pipeline

Proposed resolution

Add test coverage to ensure reliability of the module

Remaining tasks

MR

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

scott_euser created an issue. See original summary.

scott_euser’s picture

Assigned: scott_euser » Unassigned
Status: Active » Needs review

Added some basic test coverage which unfortunately led me to needing to fix two issues (could be raised separately but the tests here help prove the issues);

  1. The info.yml pointed to a non-existent settings form route. Updated to point to the one in your routing yaml file.
  2. The set_error_handler completely overrode Drupal's one suppressing logs well beyond what is scoped in the settings form, this allows your targeted one to still exist and let Drupal then handle the rest still (where some will be the suppressed by the null handler)

On (2) its probably better if that's an opt-in via the settings form as the module leads you to believe nothing is suppressed until you decide what to suppress, but actually that set_error_handler is already suppressing as soon as the module is enabled.

greg boggs’s picture

We could adjust the hook so it doesn't set the error handler if no config is set yet.

greg boggs’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.