Problem/Motivation

Exceptions are currently rethrown without chaining:

catch (InvalidKey $e) {
  throw new EncryptException($e);
}

Proposed resolution

We should instead rethrow with chaining to avoid adding the full stringified Halite exception to logs.

Also, we should use SensitiveParameter as I proposed upstream in #3608548: Hardening: Use SensitiveParameter attribute

Issue fork sodium-3608556

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !23

  • ptmkenny committed 4f745c6a on 3.0.x 
    fix: #3608556 Hardening: Use SensitiveParameter and rethrow Halite...
ptmkenny’s picture

ptmkenny commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.