Problem/Motivation

The docs page at https://www.drupal.org/docs/develop/drupal-apis/command-line-interface-c... says:

> Drupal's new standard highly encourages Single Responsibility using the __invoke() method on a plain class, creating one class per command.

But in core.api.php, two techniques are presented:

- inherit from Symfony Command
- plain class

If the recommended method is a plain class, these two options should be in the opposite order, and the plain class method should state it's the recommended way.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3606558-nr-bot_cmqyr117.txt549 bytesneeds-review-queue-bot

Issue fork drupal-3606558

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

joachim created an issue. See original summary.

bentomachado made their first commit to this issue’s fork.

bentomachado’s picture

FYI I'm working on this.

bentomachado’s picture

Status: Active » Needs review
needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new549 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

bentomachado’s picture

Status: Needs work » Needs review
Issue tags: +no-needs-review-bot