Problem/Motivation

Follow-up from #3384849: Different/wrong html when there is only one image

In #3384849: Different/wrong html when there is only one image we modified the photoswipe-gallery class logic.
Cases with a more-outside wrapper for a shared gallery now had to be implemented in the theme, using an override / hook.

For non-developers that's not perfect, because they can easily add classes through the UI in Fences or Views to do what's needed but can't get rid of the photoswipe-gallery class without coding. So let's add a setting to remove that class, where needed.

Steps to reproduce

See above

Proposed resolution

Add a setting to allow disabling the photoswipe-gallery class.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork photoswipe-3605485

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !148

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3384849: Different/wrong html when there is only one image

grevil made their first commit to this issue’s fork.

grevil changed the visibility of the branch 3605485-allow-combining-multiple-dirty-workaround to hidden.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#2625984: Add gallery grouping options

Just found #2625984: Add gallery grouping options as a different approach to discuss. We should close one of them or combine them.

Let's discuss internally, what's the best approach.

anybody changed the visibility of the branch 3605485-allow-combining-multiple-dirty-workaround to active.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Needs review » Needs work

@grevil: Just one comment left.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: +Needs tests
thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Status: Needs work » Reviewed & tested by the community
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Needs work

Test failures are unrelated, but this issue still has the "Needs tests" tag and there is one comment left on the MR.

grevil changed the visibility of the branch 3605485-allow-combining-multiple-dirty-workaround to hidden.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Reviewed & tested by the community

Alright, that should be it. Let's wait for the tests to succeed.

  • grevil committed aa45659d on 5.x authored by anybody 
    feat: #3605485 Allow combining multiple photoswipe images into a shared...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Nice @grevil!! :)

Let's tag a new release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.