Problem/Motivation

SiteConfigOverrider::getCacheableMetadata() varies overridden config by the site cache context but adds no cache tags (there's an @todo Add a site tag placeholder). So when a site's underlying data changes — e.g. saving the entity that provides its overrides — caches built from the overridden config are not invalidated and serve stale values.

Fix: add the current site's cache tags ($currentSite->getCacheTags()) to the override metadata for overridden config names. Site plugins that derive overrides from an entity (e.g. sites_group's GroupSitesBase, which exposes group:GID) then make saving that entity invalidate the dependent caches. Companion to sites_group #3524112: Check that group changes invalidate config overrides.

Issue fork sites-3605422

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hydra created an issue. See original summary.

hydra’s picture

hydra commented
Related issues: +#3524112: Check that group changes invalidate config overrides

hydra opened merge request !10

hydra changed the visibility of the branch 3605422-config-override-metadata to hidden.

  • hydra committed 3687ec38 on 1.x 
    task: #3605422 Config override metadata is missing the site's cache tags...
hydra’s picture

hydra commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.