Problem/Motivation

Highcharts updated their Fair Usage Policy, and will require HTTP referer and user-agent headers breaking composer install.
https://www.highcharts.com/docs/export-module/privacy-disclaimer-export#...

Proposed resolution

Switch to jsdelivr smilier to what has been done for 5.1.x & 5.2.x branches.

Issue fork charts-3601406

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mkhamash created an issue. See original summary.

mkhamash’s picture

mkhamash commented
Status: Active » Needs review

This fix for branch 5.0.x the solution is the same as what has been done in #3575378-7: Rate limits on code.highcharts.com switched to using jsdelivr.net,
Patch file:
https://git.drupalcode.org/issue/charts-3601406/-/commit/c03605313f6b3adb7d6b5d43b18a12fa767b32cc.patch

andileco’s picture

andileco commented

@mkhamash, would you consider also bumping the Highcharts version to ^12.5.0? I didn't observe any broken charts when I made the update on the 5.1.x branch. People who have the code locally can still peg to an earlier version (though probably not a good idea).

mkhamash opened merge request !206

mkhamash’s picture

mkhamash commented

I upgraded to 12.5.0 did not find any issues also so it does make since.

I have bumped Highcharts version to 12.5.0 and updated README.md installation steps (two options merge-plugin or Directly include library).

The CDN versions also does work, it seems to already have the extra js plugins for (texture pattern-fill, export-data, etc..), that the module version support.

Patch file:
https://git.drupalcode.org/project/charts/-/merge_requests/206.diff

  • andileco committed 6848e2e1 on 5.0.x authored by mkhamash 
    fix: #3601406 Switch Highcharts source from code.highcharts.com to...
nitinkumar_7’s picture

nitinkumar_7 commented

I reviewed the changes and tested the updated integration. The switch from `code.highcharts.com` to `jsDelivr` addresses the reported issue caused by the updated Highcharts Fair Usage Policy and also keeps the 5.0.x branch aligned with the changes already made in the newer branches.

I also verified that upgrading the bundled Highcharts library to 12.5.0 did not introduce any issues in my testing. Charts continued to render as expected, and the updated installation instructions in the README are clear and reflect the new setup options.

Overall, the changes resolve the reported problem while keeping the branch consistent with the newer implementations.
ready for RTBC ,

andileco’s picture

andileco commented
Status: Needs review » Fixed

Thanks for your additional review @nitinkumar_7.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.