Problem/Motivation

Before we can release a stable version, we need a test suite.

Issue fork apns_php-3600641

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !6

ptmkenny’s picture

ptmkenny commented
Title: Add test suite » Add test suite and fix identified bugs
ptmkenny’s picture

ptmkenny commented
Title: Add test suite and fix identified bugs » Add test suite, harden certificate handling

Changes in this branch:

- Fixes the production setting key from is_production to production.
- Adds configuration fields for certificate secret and production/sandbox mode.
- Saves the certificate secret from the correct field.
- Hides the saved secret using an empty password field.
- Preserves the existing secret when the password field is submitted blank.
- Canonicalizes certificate paths and rejects:
- public:// files
- Absolute paths inside the Drupal webroot
- Relative paths inside the Drupal webroot
- Symlinks targeting files inside the webroot

- Adds tests covering:
- Configuration form fields and submission
- Secret non-disclosure and blank-value preservation
- Certificate path existence, readability, and webroot security
- Missing service credentials
- Notification payloads, single/multiple recipients, badges, silent mode, responses, logging, and basic token
validation

  • ptmkenny committed 4f8005de on 1.0.x 
    task: #3600641 Add test suite, harden certificate handling

By: ptmkenny
ptmkenny’s picture

ptmkenny commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.