Problem/Motivation

As I was applying #3573814: Accordion duplicate HTML id - accordion and button(s) to a subtheme, I checked to see if there were any other spots where an ID was unintentionally being inherited into a button from a parent component and found that this same thing happens in the carousel.

Proposed resolution

Where buttons are used within the carousel component, pass an empty string for the ID to prevent the carousel's ID from being inherited and used.

Issue fork radix-3596853

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cyu created an issue. See original summary.

cyu’s picture

cyu commented
Issue summary: View changes

cyu opened merge request !171

cyu’s picture

cyu commented
Status: Active » Needs review

doxigo made their first commit to this issue’s fork.

  • doxigo committed fe0c555f on 6.0.x 
    fix: #3596853 - prevent buttons in carousel from duplicating parent id
doxigo’s picture

doxigo commented
Status: Needs review » Fixed

Thanks a lot Christopher, merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.