The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 12.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD12" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD12" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD12" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD12" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 12 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
Issue fork convivial_profiler-3596744
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.
Currently Drupal Rector, version dev-main, cannot fix all Drupal 12 compatibility problems.
Therefore, these changes did not update the
info.ymlfile for Drupal 12 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #6
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.
Currently Drupal Rector, version 1.0.0-beta1, cannot fix all Drupal 12 compatibility problems.
Therefore, these changes did not update the
info.ymlfile for Drupal 12 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #7
skipper-vp commented1. This adds PHP attributes for the OOP hook conversion, so keeping ^9.5 may be unsafe because Drupal 9.5 can still run on PHP versions that cannot parse attributes. Should the requirement be tightened to something like ^10.1 || ^11 || ^12?
2. There may be another Drupal 12 prep item missing: the custom profiler plugin managers still use annotation-only discovery via AnnotatedClassDiscovery. For D12, we should likely add attribute-based discovery while keeping annotation support as the legacy fallback.
Comment #8
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.
Currently Drupal Rector, version 1.1.1, cannot fix all Drupal 12 compatibility problems.
Therefore, these changes did not update the
info.ymlfile for Drupal 12 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #10
radimklaskaReviewed MR !18. Eleonel's work looks good.
I pushed 3 commits fixing the two failing CI jobs (phpcs, cspell - both allow_failure, so the pipeline looked green):
1. Re-synced the Hook classes and .module stubs from the bot's current branch - the MR had the June 11 bot output with PSR-12-style formatting (phpcs: 4 errors on 1.0.x vs 103 on the MR). Also makes pageAttachments() non-static per the bot's latest interdiff.
2. Converted ConvivialProfilerHooks to dependency injection - the phpcs job fails on warnings, and with proper formatting the \Drupal-in-classes sniff flags the three calls. Explicit services.yml arguments, since autowire aliases aren't guaranteed on 10.2.
3. cspell: "Intialize" typo, .cspell-project-words.txt for "cookieconsent", extra EOF newline in .install.
phpcs and cspell now both exit clean (verified with CI's versions). Since there are no automated tests, I tested on Drupal 11.3.10 with convivial_core 1.0.3: help pages, page attachments from config, a request_path visibility condition gating correctly (covers the injected services), settings form save, and profiler list reorder - no PHP errors.
All green on https://git.drupalcode.org/issue/convivial_profiler-3596744/-/pipelines/... now.
Leaving at Needs review - Eleo's commits are OK, but my 3 commits need a second look.
Comment #11
radimklaskaI also triggered next/previous major and max PHP tests manually.
All green except phpstan (previous major).
"Hook / LegacyHook does not exist" - those attribute classes only exist since Drupal 11.1, so static analysis against D10 can't resolve them. This is OK - on D10 the procedural stubs are what actually run. And just to be sure, I tested the module in a D10.2 sandbox: install, help pages, page attachments, visibility conditions and both forms all work.
Comment #12
eleonelI reviewed your commits Radim, looking good.
Comment #14
eleonel