Problem/Motivation
The local task styles for narrow viewports got broken. Git bisect places this with commit e9065446e20, for #3590364: Part 2 of Consolidate, refactor, remove and untangle Claro's CSS from Default Admin theme.
Screenshots of the local tasks at /admin/appearance/settings/default_admin in dark and light mode with a narrow viewport, for commits f6c6aec7302 and 2742c2ebe65, respectively:
Dark mode, @f6c6aec7302:

Dark mode, @2742c2ebe65:

Light mode, @f6c6aec7302:

Light mode, @2742c2ebe65:

Some of the color combinations fail WCAG SC 1.4.3 Contrast (Minimum) (Level AA).
Steps to reproduce
- Set admin theme to Default Admin.
- Go to
/admin/appearance/settings/default_admin. - Reduce window width until the level one local tasks appear as a dropdown menu (approximately 760 px).
- Observe the local tasks in both light and dark mode.
Differences
On a higher level, it looks like a lot of Claro styles are currently in effect.
- Side border color for active item.
In dark mode, this is a WCAG color contrast failure (contrast is 1.74:1) - Button styles.
- Button left border.
- Dark mode background colors (uncertain which is correct).
- Border radii.
Proposed resolution
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3595092-12-dark-mode-@f6c6aec7302.png | 36.77 KB | kentr |
| #10 | 3595092-9-light-mode-@f6c6aec7302.png | 36.33 KB | kentr |
| #10 | 3595092-9-light-mode-current.png | 34.65 KB | kentr |
| #10 | 3595092-9-dark-mode-current.png | 34.8 KB | kentr |
| #8 | Content_blocks___Drush_Site-Install_and_Downloads_and_HQ_Windows_11_Desktop.png | 54 KB | mherchel |
Issue fork drupal-3595092
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3595092-regression-local-tasks
changes, plain diff MR !16024
Comments
Comment #2
kentr commentedComment #5
debdeep.mukhopadhyay commentedHi @kentr,
I was able to reproduce this issue locally and found that the background-color on .tabs__trigger and .tabs__link was causing the problem in dark mode. The attached PR makes those elements transparent in gin--dark-mode, which appears to restore the expected behavior.
I also noticed a separate WCAG 1.4.3 contrast warning for the "Expand sidebar" label while testing with Accessibility Insights. If needed, I'd be happy to look into that in a follow-up.
For transparency, I used AI assistance while investigating the issue and drafting this comment, but the testing, verification and solution were done manually on my local setup.
Comment #6
kentr commented@debdeep.mukhopadhyay,
Thanks. I saw this also. For the most part, the accessibility team has been waiting on the CSS to stabilize before filing new issues. See #3582351-8: [Meta] Clean up CSS within Admin theme.
Some issues have spontaneously resolved with all of the refactoring, such as #3576874: Toggle switches are visually broken within dialog modals.
I created this issue because it was clearly a regression from #3590364: Part 2 of Consolidate, refactor, remove and untangle Claro's CSS from Default Admin theme, and I thought the maintainers would want to know about it ASAP.
Comment #7
kentr commentedI reported the issue with the Navigation top bar, which includes the Expand sidebar button, here: #3592061: List of visual differences between Gin & Admin theme
Comment #8
mherchelThis one got fixed in #3599680: Consolidate, merge, and refactor Gin's CSS variable's into Admin theme's original variables.. We don't normally fix unrelated issues, but since we're in a hurry to meet the 11.4.0 deadline, and was refactoring that anyway, I fixed it.
Comment #10
kentr commentedNot all of the colors got fixed:
There are others, such as border radii and light mode colors. On a higher level, it looks like a lot of Claro styles are currently in effect.
I'm rescoping this because creating new issues is a PITA.
Screenshots:
Dark mode, current:
Light mode, @f6c6aec7302:
Light mode, current:
Comment #11
kentr commentedComment #12
kentr commentedComment #13
kentr commentedComment #14
kentr commentedComment #15
kentr commentedComment #16
kentr commentedSummarizing our Slack discussion regarding the Claro styling:
It's intentional that some of the styling is Claro instead of the original Default Admin, because it matches the current verstion of Gin. This version looks different than the version that was merged into core.