Problem/Motivation

PHP Attributes are replacing annotations. These allow better syntax checking, and move away from the "code in comments" pattern of older annotations.

Steps to reproduce

Proposed resolution

I think the CKEditor plugins will have to stay as annotations while D10 is still supported, but the filter can move to an Attribute.
I have converted it and tested against D10.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork token_filter-3594074

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

lostcarpark opened merge request !26

lostcarpark’s picture

lostcarpark commented
Status: Active » Needs review

Converted TokenFilter to attribute.

darvanen made their first commit to this issue’s fork.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Reviewed & tested by the community

LGTM, needed rebasing (twice! lol)

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.