Problem/Motivation

PHP 8 supports declaration of properties in class constructors. This is more concise, and the recommended pattern for modern Drupal.

Steps to reproduce

Proposed resolution

  • Remove distinct property declarations.
  • Mark constructors protected.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork token_filter-3594069

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

lostcarpark opened merge request !25

lostcarpark’s picture

lostcarpark commented
Status: Active » Needs review

Moved property declarations into constructors. Verified tests pass.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Reviewed & tested by the community

Thank you for this bit-sized piece to review, I've added it to the commit train

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.