I have got this error message:

In Container.php line 147:

Circular reference detected for service "logger.raven", path: "advancedqueue.processor -> logger.factory -> logger.raven -> Drup
al\commerce\Hook\CommerceHooks -> commerce.inbox_message_fetcher -> http_client -> http_client_factory -> GuzzleHttp\HandlerStac
k -> http_client_middleware.raven -> raven.request_subscriber".

Issue fork raven-3593734

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

brtamas created an issue. See original summary.

brtamas’s picture

brtamas commented
Assigned: brtamas » Unassigned
Status: Needs work » Needs review

Possible fix:

https://git.drupalcode.org/project/raven/-/merge_requests/69

brtamas opened merge request !69

mfb’s picture

mfb
they or he
commented
Status: Needs review » Postponed (maintainer needs more info)

@brtamas Please add steps to reproduce to the issue summary (or you could also write a test that fails without the patch). Thanks for the report!

mfb’s picture

mfb
they or he
commented

We might also be able to refactor things such that http_client_middleware.raven no longer depends on raven.request_subscriber. IIRC, this is only to make use of the sanitizeBaggage() method, but perhaps sanitizeBaggage() could be a static method instead?

mfb opened merge request !70

mfb’s picture

mfb
they or he
commented

@brtamas could you check if MR 70 resolves your issue (after rebuilding the container to remove the dependency on raven.request_subscriber)

I don't (yet) know how to reproduce the issue, so I'm unable to test.

mfb’s picture

mfb
they or he
commented

@brtamas could you check if MR 70 resolves your issue, after clearing caches/rebuilding the container?

mfb’s picture

mfb
they or he
commented
Status: Postponed (maintainer needs more info) » Needs review

  • mfb committed 515efb19 on 7.x 
    fix: #3593734 Circular reference - logger

By: mfb
By: brtamas
mfb’s picture

mfb
they or he
commented
Status: Needs review » Fixed

🤷 Well hopefully this resolves the issue?

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mfb closed merge request !69

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.