Problem/Motivation

In the 11.4 prep cycle we did a large amount of refactoring in locale and introduced value objects where helpful.

For BC we preserved the array keys as properties, but found many are not necessary.
Let's deprecate them now that we can.
#3037031: Convert locale.compare.inc to a service
#3569328: Modernize locale.translations.inc
#3581303: Convert locale batch callbacks
#3577671: Modernize locale file handling
#3572339: Modernize locale.fetch.inc
#3590050: Deprecate and replace locale_status related functions
#3037156: Modernize locale history functions

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3593731

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

nicxvan created an issue. See original summary.

berdir made their first commit to this issue’s fork.

berdir’s picture

Title: Clean up locale value object » Clean up properties on LocaleTranslatableProject, LocaleTranslationSource and LocaleFile objects, stricter type validation
Status: Active » Needs review

Mostly straightforward, requires quite a lot of phstan-ignore annotations as I didn't want to remove the writes yet, just in case someone still incorrectly passes things around through BC layers, should be extremely rare though.