Problem/Motivation

Two related bugs prevent site overrides from working for entity types that do not register an explicit edit form handler (e.g. taxonomy_term, which only registers a default handler).

Issue fork sites_content_overrides-3593042

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

valegole created an issue. See original summary.

valegole opened merge request !22

valegole’s picture

valegole commented
Status: Active » Needs review

hydra made their first commit to this issue’s fork.

hydra’s picture

hydra commented

Rebased this MR onto current 1.x. The branch was based on a commit before the snapshot-model refactor (f3d1a5b), so merging it as-is would have reverted that rewrite. The two fixes (form-class edit ?? default fallback, and keeping parent in #limit_validation_errors) apply cleanly to the refactored code.

Also added test coverage:

Kernel (TaxonomyOverrideTest): asserts entity types with only a default form handler get a site_override form class.
Functional (TaxonomyOverrideFormTest + a small fixture module with a content-bearing Site plugin): edits and saves a taxonomy_term override through the UI, confirming it no longer fatals in TermForm::buildEntity() and that the non-overrideable parent is preserved.

hydra’s picture

hydra commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.