Problem/Motivation

Fix broken CI Pipeline and fix code style (phpcs. phpstan, styleint, cspell, eslint, ...)

Currently the pipeline is red and yellow ;)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork dropdown_language-3593003

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3348447: Write tests

farzana.farook made their first commit to this issue’s fork.

mildertechnologies’s picture

mildertechnologies commented
Assigned: Unassigned » mildertechnologies

kieran.cott made their first commit to this issue’s fork.

kieran.cott opened merge request !40

kieran.cott’s picture

kieran.cott
Location 🇬🇧 United Kingdom
commented
Assigned: mildertechnologies » Unassigned
Status: Active » Needs review

Pipelines now pass on MR 40.

kieran.cott’s picture

kieran.cott
Location 🇬🇧 United Kingdom
commented
Status: Needs review » Reviewed & tested by the community

Thanks for merging @skaught, will leave it to you as maintainer to move to fixed when you're ready.

skaught’s picture

skaught
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Cheers @Kieran. -- thanks for you!!

general note:
all work on active dev line for 4.1. As I am starting 4.1.x branch for D12 specifics (lifespan, usage tracking) planning releases from #3593755: Prepare Core Modernization Release

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

kieran.cott’s picture

kieran.cott
Location 🇬🇧 United Kingdom
commented

Thanks @skaught - just to make sure I've understood, by "all work on active dev line for 4.1." - do you mean that active dev work should go into 4.2.x?

skaught’s picture

skaught
Primary language English
commented

yes: 4.1.x is still the active/default branch for this project. please do continue under this

4.2.x is strictly for Drupal 12 -- i'm only releasing that as dev for now. I'll be keeping it otherwise parallel. #3601183: Automated Drupal 12 compatibility fixes for dropdown_language (hook help conversion)

FYI: as you may notice, all releases for this project as be core version really.. I prefer to be able to monitor usage this way..
10,207 sites report using this module

kieran.cott’s picture

kieran.cott
Location 🇬🇧 United Kingdom
commented

Got it - thanks for clarifying!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.