Problem/Motivation

Follow-up on #2253257: Use a modal for entity delete operation links where entity delete operation links were changed to open a modal instead of showing the form on a separate page (using use-ajax on links). This is often helpful and nice, but the current implementation doesn't open the links in a new tab using Ctrl+click or middle mouse button, which is expected and would be very helpful for batch-deleting in tabs.

Using "Open in a new tab" works fine using right mouse click browser context menu. But what doesn't work is using Ctrl+Click or middle mouse button.

I use this very frequently to mass-click such links for example deleting several views fast using tabs. Ctrl+Click should just work as expected and open the link in a new tab.

Similar old Drupal 7 issue: #3565861: Add support for Ctrl + click in Search, or add as setting option?

Steps to reproduce

Use Ctrl+Click or middle-mouse click on Views "delete" links at /admin/structure/views or other places in core where modals are used.

Expected result: Open the confirmation in a new tab
Actual result: Modal loads, no tab opened

Proposed resolution

Ensure expected behavior

Remaining tasks

Test
Release

User interface changes

Introduced terminology

API changes

None

Data model changes

None

Release notes snippet

Issue fork drupal-3592504

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Component: system.module » entity system
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

I assume this needs to be fixed in core/drupal.dialog.ajax. Should we move this? For example to component "Javascript"?

anybody opened merge request !15915

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Component: entity system » javascript
Status: Active » Needs review
Issue tags: +Site builder experience (SX)

I prepared a fix, works like a charm for me and fixes the issue, please review. Efficient editing is back ;)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
mstrelan’s picture

mstrelan commented

Thank you for this, it upsets me greatly when default browser behaviour is broken in an attempt to "simplify" interfaces.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Category: Task » Bug report

Thank you @mstrelan! Could you give it a try? Should we add any kind of test?
I think this is more kind of a bug fix looking at the UX?

mstrelan’s picture

mstrelan commented

I tested with Ubuntu on both Firefox and Chromium with Demo Umami and the /admin/content view. Before (on main) only middle click worked as expected. After, middle click and Ctrl+click both opened in a new tab, and a regular click opened the dialog. I also tested with the keyboard, tabbing through the dropbutton to select Delete, pressing Enter opened the dialog whereas pressing Ctrl+Enter opened the new tab as expected.

Would RTBC but I think someone better versed in frontend code should review it.

mstrelan’s picture

mstrelan commented

As for test coverage, we have Drupal\Tests\node\FunctionalJavascript\NodeDeleteConfirmTest that confirms the dialog still works for a normal click. I investigated what it would take to try simulate ctrl+click and detect new tabs and have decided it's not worth it. I think we can live without it here.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Personally can't say I use these keys often but seems like a small enough change that doesn't negatively impact anyone and quality of life improvement for others who do.

Tested manually using the steps mentioned. Cnt + Click on views deleted opened the modal. With the MR opened in a new tab.

Changes seems small enough probably don't need dedicated test coverage and as mentioned clicking is still working as before.

Not 100% sure a bug or feature request but will leave that as is.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks for the valuable feedback @smustgrave! Happy to see this fixed soon. :)

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

Doesn't a change like this need a change record?

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

@benjifisher, thanks for noticing that. And the policy does state a change records should be added "When the change impacts the User Interface (UI), including CSS changes.} and is a "A change in the user experience".

mstrelan’s picture

mstrelan commented

I wouldn't have thought a bug fix needs one. The modal broke standard browser behaviour, this is restoring it.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@benjifisher I agree with @mstrelan and the implementation does not change regular click behaviour, just allows regular use again, like before. Please make the final decision. Thanks!