Problem/Motivation

The module marks certain valid URLs as invalid-url, this happens with two types of URLs that are syntactically correct:

CommentFileSizeAuthor
#4 without-MR-changes.png61.84 KBdkmishra
#4 with-MR-changes.png61.83 KBdkmishra

Issue fork entity_mesh-3591294

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

frouco created an issue. See original summary.

eduardo morales alberti made their first commit to this issue’s fork.

eduardo morales alberti opened merge request !77

dkmishra’s picture

dkmishra commented
StatusFileSize
new with-MR-changes.png61.83 KB
new without-MR-changes.png61.84 KB

Verified the branch addresses both reported cases. Query-only relative URLs like `?page=10` are now validated as relative URLs, and SafeLinks-style URLs containing raw pipe characters are normalized before `UrlHelper::isValid()` runs. Please see the screenshots.

Without MR changes
Valid URLs

With MR changes
Valid URLs

Tested and RTBC +1

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Parent issue: » #3508020: Auto references are not listed on entity_mesh tables
eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Assigned: Unassigned » eduardo morales alberti
eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Active » Reviewed & tested by the community

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Fixed!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.