Problem/Motivation

ProcessorPluginBase::checkEntitiesAccess() does this:

> $access_result = $access->access($entity, 'view', return_as_object: TRUE);

Given only the facet label is output, 'view label' would be more appropriate?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork facets-3590916

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

aayushpathak’s picture

aayushpathak commented
Assigned: Unassigned » aayushpathak

aayushpathak opened merge request !377

aayushpathak’s picture

aayushpathak commented
Assigned: aayushpathak » Unassigned
Status: Active » Needs review
joachim’s picture

joachim commented
Status: Needs review » Needs work

There's an unrelated whitespace removal, but apart from that looks good.

aayushpathak’s picture

aayushpathak commented
Status: Needs work » Needs review

Thanks, fixed the unrelated whitespace change introduced during phpcbf formatting.

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Thanks! Looks good.

mnico’s picture

mnico commented
Related issues: +#3545467: Incorrect access check for 'view label' permission

strykaizer made their first commit to this issue’s fork.

  • strykaizer committed aa017395 on 3.0.x 
    Issue #3590916: checkEntitiesAccess should use 'view label' rather than...
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.