Problem/Motivation

We have a class extending from MigrateBatchExecutable. After #3067165: Option to override batch size our tests started failing. This was caused by a change in \Drupal\migrate_tools\MigrateBatchExecutable::batchProcessImport. Previously it constructed a new executable by using new static but now it calls new MigrateBatchExecutable, meaning our overridden methods were not called.

Steps to reproduce

Proposed resolution

Revert to new static, or mark the class as @internal or @final and note it shouldn't be extended.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork migrate_tools-3590774

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !106

mstrelan’s picture

mstrelan commented
Status: Active » Needs review

Let's see how this goes.

  • heddn committed d6d0296e on 6.1.x authored by mstrelan 
    fix: #3590774 Extending MigrateBatchExecutable broken since 6.1.4

By:...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Fixed

Thanks for the fixes here.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.