Problem/Motivation

For some content, it would be preferable to override the default "paged" display behaviour of this module.

An example might be where most content is paged by default, but one or two pages benefit from being displayed in full when there is no query parameter to select the behaviour.

Steps to reproduce

Unless ?full is in the URL, the behaviour of this module at present is to always page content (ref) when the sector_multipage/sector_multipage library is attached.

Proposed resolution

  1. Expose interface to determine behaviour (drupalSettings.sectorMultipage.defaultPagingMode
  2. Provide module configuration for this
  3. In JS library, behaviour is determined by (order of precedence): query parameter, JS setting above, site configuration, existing default (paged)

Remaining tasks

Discuss, implement, etc

User interface changes

Admin user interface

API changes

Expose interface (Drupal JS setting) to determine behaviour

Data model changes

n/a

Issue fork sector_multipage-3590546

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xurizaemon created an issue. See original summary.

xurizaemon opened merge request !15

ericgsmith’s picture

ericgsmith commented

I know this is not set to needs review but it looks pretty complete and test coverage is great. I have a minor comment that I will implement.

Intent will be to get this merged then I will take a 1.1.0-rc1 with this change - happy to wait a while before moving it to a full 1.1.0 in case there was anything remaining here.

ericgsmith’s picture

ericgsmith commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.