This is a placeholder for issue https://git.drupalcode.org/project/ai/-/work_items/3586436

Issue fork ai_content_suggestions-3589952

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

a.dmitriiev created an issue. See original summary.

a.dmitriiev’s picture

a.dmitriiev commented

The upstream issues is closed now and the code was added to 1.4.2 version of AI Core. So this module needs to sync with AI Core.

a.dmitriiev opened merge request !5

a.dmitriiev’s picture

a.dmitriiev commented
Status: Active » Needs review

I have created MR to cherry-pick the changes from the AI Core repo for this issue.

jucs7’s picture

jucs7 commented
Assigned: Unassigned » jucs7
jucs7’s picture

jucs7 commented

The changes match the upstream implementation: getPluginResponse is now in AiContentSuggestionsPluginBase, the plugins use the instance method as ajax callback, and dependency injection is used. The MR also includes a small spelling fix in tests/src/Kernel/EntityTypeFilterTest.php

Pipelines are green and everything looks good to me. Moving to rtbc.

jucs7’s picture

jucs7 commented
Assigned: jucs7 » Unassigned
Status: Needs review » Reviewed & tested by the community
erichomanchuk’s picture

erichomanchuk commented
Version: 1.3.0 » 1.4.1
erichomanchuk’s picture

erichomanchuk commented
Status: Reviewed & tested by the community » Fixed

This has been merged into 1.4.x as tag 1.4.1

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

erichomanchuk closed merge request !5

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.