'Show only one result' is not yet available for exposed filters.

Issue fork facets-3588925

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mkalkbrenner created an issue. See original summary.

mkalkbrenner opened merge request !374

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Active » Needs review

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs review » Fixed

Merged after talking to Jimmy.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

caesius’s picture

caesius commented
Related issues: +#3594309: Broken/missing handler after update to Facets 3.0.4: Restore facets_exposed_filters.module file and use LegacyHook for Drupal 10

Why did this apparently very simple issue result in a large OO code migration that breaks Drupal 10 compatibility?

And who is "Jimmy?"

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented

Jimmy here ;)

I agree that the OO hooks shouldn't have been introduced in this issue, but they have now, so lets fix it in #3594309: Broken/missing handler after update to Facets 3.0.4: Restore facets_exposed_filters.module file and use LegacyHook for Drupal 10 and make a new release.

@caesius reminder that every contributor on facets and search does this work for free.
Please be kind ;-) We are all humans.

caesius’s picture

caesius commented

@strykaizer Thank you for addressing this, and for agreeing that the OO hooks refactor was inappropriate here. I also understand that the OO refactor would've been very easy to overlook just from commit messages between 3.0.3 and .4, but some additional guidance or guardrails would help prevent this from happening again in the future. Even something simple like "check the diff size, if it's >X lines release a minor instead of patch." I opened Document SemVer compliance and release process with exactly that suggestion.