Problem/Motivation

Drupal 12 should ship with Symfony 8.1, and https://github.com/symfony/symfony/releases/tag/v8.1.1 is out.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3588847

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs work

Ran into https://github.com/sebastianbergmann/phpunit/issues/6545 so we need to bump PHPUnit as well, though still getting errors locally on unit tests.

longwave’s picture

Status: Needs work » Needs review
needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

longwave’s picture

Status: Needs work » Needs review
needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new583 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

longwave’s picture

Title: Update to Symfony 8.1.0-beta1 » Update to Symfony 8.1.0-beta3
longwave’s picture

Title: Update to Symfony 8.1.0-beta3 » Update to Symfony 8.1
Priority: Normal » Major
Status: Needs work » Needs review
needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

longwave’s picture

Issue summary: View changes
Status: Needs work » Needs review

Rebased and updated to Symfony 8.1.1

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new2.85 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

longwave’s picture

Status: Needs work » Needs review
$ composer-lock-diff --from=main --no-links
+------------------------------------+---------+---------+
| Production Changes                 | From    | To      |
+------------------------------------+---------+---------+
| symfony/console                    | v8.0.11 | v8.1.1  |
| symfony/dependency-injection       | v8.0.10 | v8.1.1  |
| symfony/deprecation-contracts      | v3.7.0  | v3.7.1  |
| symfony/error-handler              | v8.0.8  | v8.1.0  |
| symfony/event-dispatcher           | v8.0.9  | v8.1.1  |
| symfony/event-dispatcher-contracts | v3.7.0  | v3.7.1  |
| symfony/filesystem                 | v8.0.11 | v8.1.0  |
| symfony/finder                     | v8.0.8  | v8.1.1  |
| symfony/http-foundation            | v8.0.13 | v8.1.1  |
| symfony/http-kernel                | v8.0.12 | v8.1.1  |
| symfony/mailer                     | v8.0.12 | v8.1.1  |
| symfony/mime                       | v8.0.12 | v8.1.0  |
| symfony/polyfill-intl-grapheme     | v1.37.0 | v1.38.1 |
| symfony/polyfill-intl-normalizer   | v1.37.0 | v1.38.0 |
| symfony/polyfill-mbstring          | v1.37.0 | v1.38.2 |
| symfony/polyfill-php86             | v1.37.0 | v1.38.0 |
| symfony/process                    | v8.0.11 | v8.1.0  |
| symfony/psr-http-message-bridge    | v8.0.8  | v8.1.0  |
| symfony/routing                    | v8.0.13 | v8.1.0  |
| symfony/runtime                    | v8.0.12 | v8.1.0  |
| symfony/serializer                 | v8.0.10 | v8.1.1  |
| symfony/service-contracts          | v3.7.0  | v3.7.1  |
| symfony/string                     | v8.0.11 | v8.1.0  |
| symfony/translation-contracts      | v3.7.0  | v3.7.1  |
| symfony/validator                  | v8.0.10 | v8.1.1  |
| symfony/var-dumper                 | v8.0.8  | v8.1.1  |
| symfony/var-exporter               | v8.0.9  | v8.1.1  |
| symfony/yaml                       | v8.0.12 | v8.1.1  |
| symfony/polyfill-deepclone         | NEW     | v1.40.0 |
+------------------------------------+---------+---------+

+---------------------------+---------+---------+
| Dev Changes               | From    | To      |
+---------------------------+---------+---------+
| phpunit/php-code-coverage | 12.5.3  | 12.5.6  |
| phpunit/phpunit           | 12.5.14 | 12.5.24 |
| sebastian/comparator      | 7.1.4   | 7.1.6   |
| sebastian/environment     | 8.0.4   | 8.1.0   |
| symfony/browser-kit       | v8.0.8  | v8.1.1  |
| symfony/css-selector      | v8.0.9  | v8.1.0  |
| symfony/dom-crawler       | v8.0.12 | v8.1.1  |
| symfony/lock              | v8.0.9  | v8.1.1  |
+---------------------------+---------+---------+
longwave’s picture

Crediting @mstrelan for #3607060: ConsoleCompilerPass incompatible with symfony/console ≥ 8.1 which I merged in here, as all the test fails look related to that.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

longwave’s picture

Status: Needs work » Needs review
longwave’s picture

Priority: Major » Critical

Bumping to critical in the hope I can avoid rerolling this yet again :D

godotislate’s picture

Status: Needs review » Needs work

Nice work! One tiny suggestion and a few questions on the MR.

Lots of deprecations to handle in follow ups, including symfony/validator again...
Also, does Symfony really intend for the Request/Response objects not to be mocked?

longwave’s picture

Status: Needs work » Needs review

Rebased and fixed or responded to all comments.

I don't think it's intended, but it's a side effect of Symfony now using get/set property hooks in Request/Response. It's related to https://github.com/sebastianbergmann/phpunit/issues/6545 from what I remember which is why we had to upgrade PHPUnit here. There might be a better way, not sure?

longwave’s picture

To be honest though it makes the code cleaner where we can actually use real Request/Response objects instead of creating mocks.

The comment "The thing is: those public properties were not meant to be set from outside" also I guess means that we were never meant to do this anyway, even in tests.

godotislate’s picture

Status: Needs review » Reviewed & tested by the community

lgtm!

  • catch committed 169100e3 on main
    task: #3588847 Update to Symfony 8.1
    
    By: longwave
    By: mstrelan
    By:...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Looks good to me too, most of the changes look like net improvements, a few things added to the phpstan baseline but those are eventual Symfony 9 blockers, better to get on 8.1 as early as possible.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

godotislate’s picture

We might need a meta/issue to deal with the deprecations? #3449808: [12.x] [meta] Requirements for tagging 12.0.0-beta1 has a line item for "Address usage of upstream deprecations (PHP, dependencies, etc.)" but no issue yet.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.