Closed (fixed)
Project:
Drupal core
Version:
main
Component:
composer
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 May 2026 at 21:10 UTC
Updated:
11 Aug 2026 at 14:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
longwaveRan into https://github.com/sebastianbergmann/phpunit/issues/6545 so we need to bump PHPUnit as well, though still getting errors locally on unit tests.
Comment #4
longwaveComment #5
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #6
longwaveComment #7
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #8
longwavehttps://github.com/symfony/symfony/releases/tag/v8.1.0-BETA3 is out.
Comment #9
longwaveComment #10
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #11
longwaveRebased and updated to Symfony 8.1.1
Comment #12
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #13
longwaveComment #14
longwaveCrediting @mstrelan for #3607060: ConsoleCompilerPass incompatible with symfony/console ≥ 8.1 which I merged in here, as all the test fails look related to that.
Comment #15
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #16
longwaveComment #17
longwaveBumping to critical in the hope I can avoid rerolling this yet again :D
Comment #18
godotislateNice work! One tiny suggestion and a few questions on the MR.
Lots of deprecations to handle in follow ups, including
symfony/validatoragain...Also, does Symfony really intend for the Request/Response objects not to be mocked?
Comment #19
longwaveRebased and fixed or responded to all comments.
I don't think it's intended, but it's a side effect of Symfony now using get/set property hooks in Request/Response. It's related to https://github.com/sebastianbergmann/phpunit/issues/6545 from what I remember which is why we had to upgrade PHPUnit here. There might be a better way, not sure?
Comment #20
longwaveTo be honest though it makes the code cleaner where we can actually use real Request/Response objects instead of creating mocks.
The comment "The thing is: those public properties were not meant to be set from outside" also I guess means that we were never meant to do this anyway, even in tests.
Comment #21
godotislatelgtm!
Comment #23
catchLooks good to me too, most of the changes look like net improvements, a few things added to the phpstan baseline but those are eventual Symfony 9 blockers, better to get on 8.1 as early as possible.
Comment #25
godotislateWe might need a meta/issue to deal with the deprecations? #3449808: [12.x] [meta] Requirements for tagging 12.0.0-beta1 has a line item for "Address usage of upstream deprecations (PHP, dependencies, etc.)" but no issue yet.