Problem/Motivation

There are multiple test failures on 11.x

One is from #3533299: Deprecate node access rebuild functions, see #59:

Basically, with DependencySerializationTrait, the service property is being re-initialized from the container in __wakeup(), which is causing an error because it is readonly and can not be set outside the constructor.

Two are from #3581109: Move HelpSearch to Search sub-module: need to install mysqli in update tests.

Last is from #3184242: Support brotli compression of assets: similar issue with needing mysqli in an update test.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3588558

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

godotislate created an issue. See original summary.

godotislate’s picture

godotislate
he/him
commented
Related issues: +#3581109: Move HelpSearch to Search sub-module, +#3184242: Support brotli compression of assets

godotislate opened merge request !15681

godotislate’s picture

godotislate
he/him
commented
Status: Active » Needs review

MR https://git.drupalcode.org/project/drupal/-/merge_requests/15681

MR jobs for PHP 8.3 with PostgreSQL, mysqli, and SQLite all green
https://git.drupalcode.org/project/drupal/-/pipelines/813515

Last 11.x commit with test failures:
https://git.drupalcode.org/project/drupal/-/pipelines/813348

godotislate’s picture

godotislate
he/him
commented

One question is whether the readonly should also be removed in main, but I don't think that's a BC break.

nicxvan’s picture

nicxvan commented

They aren't in a release yet afaict, should be safe to change on main.

godotislate’s picture

godotislate
he/him
commented

Oh, sorry, I meant that if we leave main with readonly, then a site going from 11.4 to 12.0 could hit issues if there are subclasses that redeclare the same property without readonly.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

I think the readonly is OK on main - properties on form controllers are supposed to be @internal.

godotislate’s picture

godotislate
he/him
commented

I wonder if we should create an issue to update the 11.3 dump (or make a new one) with mysqli installed, if there isn't already one.

catch’s picture

catch
he/him
Primary language English
commented

Yes I think that's worth doing, I thought we had an issue but can't find it right now.

godotislate’s picture

godotislate
he/him
commented

Opened #3588702: Install mysqli in test 11.3 database fixture.

godotislate’s picture

godotislate
he/him
commented

#3588702: Install mysqli in test 11.3 database fixture is ready for review. It might make sense to get that in first so we don't need to backport the mysqli fixture to 11.x here.

godotislate opened merge request !15700

godotislate’s picture

godotislate
he/him
commented

Opened Merge request !15700 which has only the readonly change, in case #3588702: Install mysqli in test 11.3 database fixture gets in first.

godotislate changed the visibility of the branch 3588558-test-failures-on to hidden.

godotislate closed merge request !15681

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !15700

godotislate’s picture

godotislate
he/him
commented

It doesn't look like the commit got pushed?

  • catch committed 78659fbb on 11.x 
    fix: #3588558 Test failures on 11.x

By: godotislate
catch’s picture

catch
he/him
Primary language English
commented

Pushed now, thanks for spotting!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.